Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion wip #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversion wip #1

wants to merge 3 commits into from

Conversation

kells1986
Copy link
Collaborator

FYI

@drstarson
Copy link

Nice! Full steam ahead!

@ivyas21
Copy link

ivyas21 commented Jun 28, 2023

Thank you @kells1986. I'm going over the notebook. Let you know how it goes.

@ivyas21
Copy link

ivyas21 commented Jun 28, 2023

The export.ipynb appears to have a typo. SamOnnxModel should be SimpleSamOnnxModel:

from segment_anything.utils.onnx import SamOnnxModel
onnx_model = SamOnnxModel(model=mobile_sam)

... should be....

from segment_anything.utils.onnx import SimpleSamOnnxModel
onnx_model = SimpleSamOnnxModel(model=mobile_sam)

Everything else looks good. I will spend more time tomorrow on it.

I pushed the export.ipynb

@ivyas21
Copy link

ivyas21 commented Jun 28, 2023 •
edited
Loading

Opps I don't have write permission to this repo. Could you please give me access? Thank you.

@kells1986
Copy link
Collaborator Author

Sorry, I forgot about that. I just added you and @drstarson as admins

@ivyas21
Copy link

ivyas21 commented Jun 28, 2023

Just pushed the notebook with minor typo fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@drstarson drstarson

@ivyas21 ivyas21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kells1986 @drstarson @ivyas21